@studiometa/ui

@@             Coverage Diff              @@
##               main     #511      +/-   ##
============================================
+ Coverage     77.46%   80.42%   +2.95%     
  Complexity      145      145              
============================================
  Files            93      100       +7     
  Lines          2698     3213     +515     
  Branches        454      612     +158     
============================================
+ Hits           2090     2584     +494     
- Misses          532      551      +19     
- Partials         76       78       +2     

Flags with carried forward coverage won't be shown. Click here to find out more.

... and 13 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Previous run archived 2026-07-16T09:34:16Z

Code Review

Risk: Medium — issues that should be addressed before merge.

This MR adds DataScope, keyed scoped $data snapshots, scoped Action targeting, and the related docs/tests around scoped Data components. Besides the scoped-group foundation described in the intent, the diff also ships the previously deferred virtual data-bind:* bindings and mutation helpers.

1 issue found:

• issue — packages/ui/Data/DataScope.ts:183 — Mirrored keyed models are not tracked

Still open from earlier reviews (19 findings):

• packages/ui/Data/DataScope.ts:184 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:252 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:48 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:94 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:286 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:414 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:222 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:134 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings
• packages/ui/Data/DataScope.ts:136 — issue: Cleared scoped keys write literal undefined
• packages/ui/Data/DataBind.ts:396 — issue: Mutation helpers bypass computed/effect dispatch
• packages/ui/Data/DataBind.ts:296 — issue: Clearing date bindings assigns an invalid value
• packages/ui/Data/DataBind.ts:338 — issue: Text virtual bindings render literal undefined
• packages/ui/Data/DataScope.ts:218 — issue: Recompute grouped checkbox values after source removal
• packages/ui/Data/DataScope.ts:166 — issue: Unkeyed scoped notifications stop at first subscriber

Review usage: 743,220 in (649,216 cached) / 16,804 out tokens — $0.6494 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 5711d5a.

Previous run archived 2026-07-16T09:27:54Z

Code Review

Risk: Medium — issues that should be addressed before merge.

This MR adds DataScope, scoped/keyed data snapshots, scoped Action target resolution, virtual data-bind:* bindings, and the new mutation helpers around the Data family. The overall shape is solid and the tests cover many of the new behaviors, but one notification path still drops updates for part of a scoped group.

1 issue found:

• issue — packages/ui/Data/DataScope.ts:166 — Unkeyed scoped notifications stop at first subscriber

Notes:

• The implementation also adds virtual data-bind:* bindings and toggle/increment/cycle mutation helpers, although the MR intent says those were deferred to follow-up work.

Still open from earlier reviews (18 findings):

• packages/ui/Data/DataScope.ts:181 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:249 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:286 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:414 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:222 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:133 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings
• packages/ui/Data/DataScope.ts:136 — issue: Cleared scoped keys write literal undefined
• packages/ui/Data/DataBind.ts:396 — issue: Mutation helpers bypass computed/effect dispatch
• packages/ui/Data/DataBind.ts:296 — issue: Clearing date bindings assigns an invalid value
• packages/ui/Data/DataBind.ts:338 — issue: Text virtual bindings render literal undefined
• packages/ui/Data/DataScope.ts:215 — issue: Recompute grouped checkbox values after source removal

Review usage: 509,862 in (434,688 cached) / 11,566 out tokens — $0.4701 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 03b0c50.

Previous run archived 2026-07-16T09:21:47Z

Code Review

Risk: Medium — issues that should be addressed before merge.

Adds the new DataScope boundary, keyed scoped $data snapshots, scoped Action target resolution, and broad docs/tests for hydration, isolation, and cleanup behavior. It also introduces virtual data-bind:* bindings plus DataBind/DataModel mutation helpers across the data stack. That last part goes beyond the MR description, which said those features were deferred to follow-up work.

1 issue found:

• issue — packages/ui/Data/DataScope.ts:182 — Recompute grouped checkbox values after source removal

Still open from earlier reviews (17 findings):

• packages/ui/Data/DataScope.ts:148 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:211 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:286 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:414 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:222 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:123 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings
• packages/ui/Data/DataScope.ts:136 — issue: Cleared scoped keys write literal undefined
• packages/ui/Data/DataBind.ts:396 — issue: Mutation helpers bypass computed/effect dispatch
• packages/ui/Data/DataBind.ts:296 — issue: Clearing date bindings assigns an invalid value
• packages/ui/Data/DataBind.ts:338 — issue: Text virtual bindings render literal undefined

Review usage: 354,759 in (216,064 cached) / 11,809 out tokens — $0.5779 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 34a6622.

Previous run archived 2026-07-16T09:16:32Z

Code Review

Risk: Medium — issues that should be addressed before merge.

Adds DataScope with inherited local groups, keyed scoped values, frozen $data snapshots for callbacks, scoped Action targeting, and extensive docs/tests around hydration and teardown behavior. The implementation also introduces virtual data-bind:* bindings and mutation helpers alongside the scope work, and the new coverage exercises many of those interactions. The MR goes beyond the stated scoped/keyed foundation by also shipping the virtual bindings and mutation helpers that the description said were deferred.

2 issues found:

• issue — packages/ui/Data/DataBind.ts:296 — Clearing date bindings assigns an invalid value
• issue — packages/ui/Data/DataBind.ts:338 — Text virtual bindings render literal undefined

Notes:

• packages/ui/Data/DataScope.ts:47 — frozen Date snapshots remain mutable through Date mutator methods; suppressed per the prior thread reply because the intended guarantee is snapshot isolation rather than deep immutability, and the JS API now documents that limitation explicitly.

Still open from earlier reviews (15 findings):

• packages/ui/Data/DataScope.ts:148 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:211 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:268 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:396 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:204 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:123 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings
• packages/ui/Data/DataScope.ts:136 — issue: Cleared scoped keys write literal undefined
• packages/ui/Data/DataBind.ts:378 — issue: Mutation helpers bypass computed/effect dispatch

Review usage: 954,516 in (784,384 cached) / 15,677 out tokens — $0.8566 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 0708054.

Previous run archived 2026-07-16T09:11:23Z

Code Review

Risk: Low — I did not find any blocking defects in this MR; it looks safe to merge.

Adds DataScope boundaries for scoped Data groups, keyed scoped values with frozen $data snapshots, scoped Action targeting, and broad test/docs coverage around hydration, isolation, and teardown behavior. The diff also introduces virtual data-bind:* bindings and DataBind/DataModel mutation helpers, which exceeds the stated intent that those pieces were deferred to follow-up work. I did not find any blocking defects in the implementation.

Notes:

• packages/ui/Data/DataScope.ts:47 — Date entries in $data snapshots remain mutation-capable via Date methods, suppressed per the prior-thread clarification that the guarantee here is snapshot isolation rather than deep immutability.

Still open from earlier reviews (15 findings):

• packages/ui/Data/DataScope.ts:148 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:211 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:268 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:396 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:204 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:123 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings
• packages/ui/Data/DataScope.ts:136 — issue: Cleared scoped keys write literal undefined
• packages/ui/Data/DataBind.ts:378 — issue: Mutation helpers bypass computed/effect dispatch

Review usage: 285,476 in (204,288 cached) / 13,340 out tokens — $0.4541 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 4e00214.

Previous run archived 2026-07-16T08:21:36Z

Code Review

Risk: Medium — issues that should be addressed before merge.

This MR adds DataScope, keyed scoped $data snapshots, scoped Action target resolution, virtual data-bind:* bindings, and new DataBind mutation helpers, with broad tests around isolation, hydration, teardown, and exports. The overall direction and coverage look solid, but the remaining edge cases above still leave observable stale or local-only state in consumers. The implementation also exceeds the stated scope by shipping virtual bindings and mutation helpers that the MR description said were deferred follow-up work.

2 issues found:

• issue — packages/ui/Data/DataScope.ts:136 — Cleared scoped keys write literal undefined
• issue — packages/ui/Data/DataBind.ts:365 — Mutation helpers bypass computed/effect dispatch

Notes:

• packages/ui/Data/DataScope.ts:47 — frozen Date snapshots remain mutable through Date methods, suppressed per the prior-thread clarification that the guarantee is snapshot isolation rather than deep immutability; the new DataScope JS API docs now state that limitation explicitly.

Still open from earlier reviews (13 findings):

• packages/ui/Data/DataScope.ts:148 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:211 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:264 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:379 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:200 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:123 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings
• packages/ui/Data/DataScope.ts:136 — issue: Key removal renders literal undefined in bindings

Review usage: 545,668 in (450,048 cached) / 18,561 out tokens — $0.6300 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 1701ae4.

Previous run archived 2026-07-16T08:14:38Z

Code Review

Risk: Medium — issues that should be addressed before merge.

This MR adds DataScope-based group isolation, keyed scoped data snapshots for the Data components, and nearest-scope target resolution for Action, with broad test and documentation coverage. It also extends DataBind with virtual data-bind:* bindings and mutation helpers while threading scoped $data through computed/effect callbacks.

1 issue found:

• issue — packages/ui/Data/DataScope.ts:136 — Key removal renders literal undefined in bindings

Notes:

• The diff also adds virtual data-bind:* bindings and toggle / increment / cycle helpers in packages/ui/Data/DataBind.ts, although the MR intent described those as deferred follow-up work.

Still open from earlier reviews (12 findings):

• packages/ui/Data/DataScope.ts:148 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:211 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:264 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:379 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:200 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:123 — issue: Radio source tracking uses wrong instance
• packages/ui/Data/DataBind.ts:33 — issue: Helper equality conflates booleans with strings

Review usage: 328,295 in (267,264 cached) / 12,666 out tokens — $0.4094 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 4327123.

Previous run archived 2026-07-16T08:11:58Z

Code Review

Risk: Medium — issues that should be addressed before merge.

Adds DataScope support across the Data components, including inherited scoped groups, keyed $data snapshots, scoped hydration/cleanup, and Action target resolution limited to the nearest scope. The MR also adds virtual data-bind:* bindings and new toggle, increment, and cycle helpers on DataBind, plus docs/tests for the expanded API.

1 issue found:

• issue — packages/ui/Data/DataBind.ts:33 — Helper equality conflates booleans with strings

Notes:

• The diff includes virtual data-bind:* bindings and mutation helpers (packages/ui/Data/DataBind.ts and related docs/tests), even though the intent said those pieces were deferred to follow-up work.

Still open from earlier reviews (11 findings):

• packages/ui/Data/DataScope.ts:129 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:188 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:257 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:372 — issue: increment() writes numbers into date bindings
• packages/ui/Data/DataBind.ts:193 — issue: DataModel inputs read stale virtual value
• packages/ui/Data/DataScope.ts:118 — issue: Radio source tracking uses wrong instance

Review usage: 551,346 in (465,408 cached) / 17,248 out tokens — $0.5899 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit 15ded99.

Previous run archived 2026-07-16T08:06:44Z

Code Review

Risk: Medium — issues that should be addressed before merge.

This MR adds DataScope, keyed scoped $data snapshots for the Data components, and nearest-scope targeting for Action. It also introduces virtual data-bind:* bindings and mutation helpers on DataBind, with broad test and docs coverage for the new scoped behavior.

2 issues found:

• issue — packages/ui/Data/DataBind.ts:195 — DataModel inputs read stale virtual value
• issue — packages/ui/Data/DataScope.ts:118 — Radio source tracking uses wrong instance

Notes:

• The diff also adds virtual data-bind:* bindings and toggle / increment / cycle mutation helpers even though the MR description says those pieces were intentionally deferred to follow-up work.

Still open from earlier reviews (9 findings):

• packages/ui/Data/DataScope.ts:129 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:181 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data
• packages/ui/Data/DataBind.ts:253 — issue: Virtual bindings drop the raw bound value
• packages/ui/Data/DataBind.ts:368 — issue: increment() writes numbers into date bindings

Review usage: 528,876 in (435,200 cached) / 17,645 out tokens — $0.6077 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit b3c709b.

Previous run archived 2026-07-16T08:00:11Z

Code Review

Risk: Medium — issues that should be addressed before merge.

Adds DataScope to isolate Data groups, keyed scoped values, $data snapshots for computed/effect callbacks, and scope-local Action target resolution. It also adds virtual data-bind:* bindings and toggle/increment/cycle helpers on DataBind, plus documentation and test coverage around those APIs. In addition to the scoped/keyed foundation, this MR also ships virtual bindings and mutation helpers even though the intent said those pieces were deferred to follow-up work.

2 issues found:

• issue — packages/ui/Data/DataBind.ts:247 — Virtual bindings drop the raw bound value
• issue — packages/ui/Data/DataBind.ts:360 — increment() writes numbers into date bindings

Still open from earlier reviews (7 findings):

• packages/ui/Data/DataScope.ts:129 — issue: Destroying a keyed source leaves stale data
• packages/ui/Data/DataScope.ts:80 — issue: Freeze nested scoped values before exposing $data
• packages/ui/Data/DataScope.ts:181 — issue: Hydration records unchecked radios as current value
• packages/ui/Data/DataScope.ts:47 — issue: Frozen Date snapshots remain mutable
• packages/ui/Data/DataScope.ts:103 — issue: Teardown rebuilds keyed data from subscribers
• packages/ui/Data/DataScope.ts:111 — issue: Destroying keyed subscribers preserves stale $data
• packages/ui/Data/DataScope.ts:93 — issue: Prune disconnected scoped sources from $data

Review usage: 437,987 in (345,088 cached) / 16,621 out tokens — $0.5678 (cloudflare-ai-gateway/gpt-5.4, thinking: medium)

Reviewed by @weareikko/code-review v0.8.2 for commit ae1626f.